chore(mongodb-ns): fix publishing ns package by renaming test file #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Sep 18, 2025
johnjackweir
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We nearly got it on the first try. Because the test file wasn't named with the "spec" pattern and allowJs was set to true TS was trying to compile index.ts and index.test.js to the same file, and it throws saying it will overwrite. I took the liberty of changing the file both to spec and TS, and unskipped the skipped tests by verifying that all those DB names are valid.
Open Questions
Can we rerun bump packages / publish with the 3.0.0 version since it never actually released or should I make this a "fix" just to get the 3.0.1 version put in the package.json?
Checklist